descibeNode for new js runtime #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
force-pushed
the
describeNode2
branch
from
bf5fe17 to
af1d49b
Compare
sjorsdonkers
force-pushed
the
describeNode2
branch
from
af1d49b to
d7f82e3
Compare
sjorsdonkers
commented
Apr 18, 2025
Collaborator
|
Looks good. I don't want to beat a dead horse, but.. It's a bit less direct, and doesn't depend on an Executor, versus: pub fn getNodePtr(self: *const Inspector, allocator: Allocator, , object_id: []const u8) !?*anyopaque {
const unwrapped = try self.session.unwrapObject(allocator, object_id);
const toa = getTaggedAnyOpaque(unwrapped.value) orelse return null;
if (toa.subtype == null or toa.subtype != .node) return error.ObjectIdIsNotANode;
return toa.ptr;
} |
Merged
krichprollsch
approved these changes
Apr 22, 2025
src/cdp/domains/dom.zig
Outdated
| if (params.nodeId != null) { | ||
| const node = bc.node_registry.lookup_by_id.get(params.nodeId.?) orelse return error.NodeNotFound; | ||
| return cmd.sendResult(.{ .node = bc.nodeWriter(node, .{}) }, .{}); | ||
| } else if (params.objectId != null) { |
Member
There was a problem hiding this comment.
you don't really need a else here isn't it?
I would prefer have:
if (params.nodeId != null) {
// ...
}
if (params.objectId != null) {
// ...
}
return error.MissingParams;
Contributor
Author
There was a problem hiding this comment.
Changed : a698ff8
Note that it is correct since every if branch returns.
The if else structure was indicating that only one of the paths should be taking.
sjorsdonkers
force-pushed
the
describeNode2
branch
from
15a5956 to
a698ff8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #524